XWIKI-21597: Make the rights UI use icon themes #2991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated the localisation method for the confirmation boxes and others * Changed the code to fit this new structure
* Removed an unneeded change
* Removed unwanted codestyle change
* Removed unwanted codestyle change
manuelleduc
reviewed
Mar 15, 2024
...b/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/usersandgroups/usersandgroups.js
Show resolved
Hide resolved
* Fixed indentation
manuelleduc
reviewed
Mar 15, 2024
| self.state = 2; | ||
| nxtst = 0; | ||
| } else { | ||
| require(['xwiki-l10n!users-and-groups-translation-keys'], function(l10n) { |
There was a problem hiding this comment.
I'm still not fully convinced by this part being asynchronous. Couldn't we define this at a more global place. cc @mflorea if you have some idea.
There was a problem hiding this comment.
I tried to require the translations above the MSCheckbox class definition, but this ended in an error in another (synchronous) script that couldn't find MSCheckbox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21597
Changes
Description
Clarifications
Screenshots & Video
21597-demo2.mp4
Executed Tests
Manual tests, see video demo.
No tests were broken by this regression, no test should be broken by fixing it.
Expected merging strategy