XWIKI-21822: A column can't be without panels #2818
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21822
Changes
Description
Currently, even if "Both columns" is selected in the Panels admin, if all the panels of one column are removed, the column will not be displayed
Warning: This is still a draft for good reason, that simple change seems to have unexpected impact and I need to run more tests.
Screenshots & Video
Main Page
Before
After
See the empty column on the right.
Panels Admins
Before
See the "Left column" being select while I only removed the panels from the rights column initially.
After
Executed Tests
Expected merging strategy