Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-21777: Admin section: make the PDF export section pass webstandard tests #2802

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Jan 17, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-21777

Changes

Description

  • Added a missing space between attributes in the pdf generator select
  • Replaced the comment with an actual test for the export PDF section

Screenshots & Video

No visual change.

Executed Tests

  • Successfully passed mvn clean install -f xwiki-platform-distribution/xwiki-platform-distribution-flavor/xwiki-platform-distribution-flavor-test/xwiki-platform-distribution-flavor-test-webstandards -Dxwiki.test.startXWiki=false after updating the live distribution with the changes in this PR.

Expected merging strategy

  • Prefers squash: Yes
  • Merge only on master.

…ard tests

* Added a missing space between attributes in the pdf generator select
* Replaced the comment with an actual test for the export PDF section
@surli surli merged commit 8f1e78a into xwiki:master Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants