CRISTAL-257: The edit button is presented even if the current user do…

…es not have edit rights * Hide edit button when edition is disabled * Improve comments
xwiki-contrib · Dec 23, 2024 · 9de0786 · 9de0786
1 parent 6d82a3e
commit 9de0786
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/core/backends/backend-xwiki/src/xwikiStorage.ts b/core/backends/backend-xwiki/src/xwikiStorage.ts
@@ -149,7 +149,7 @@ export class XWikiStorage extends AbstractStorage {
     try {
       json = await response.json();
       if (!response.ok) {
-        // TODO: Fix CRISTAL-383
+        // TODO: Fix CRISTAL-383 (Error messages in Storages are not translated)
         this.alertsServiceProvider
           .get()
           .error(`Could not load page ${page}. Reason: ${json.error}`);
@@ -318,7 +318,7 @@ export class XWikiStorage extends AbstractStorage {
     });
     if (!response.ok) {
       const errorMessage = await response.text();
-      // TODO: Fix CRISTAL-383
+      // TODO: Fix CRISTAL-383 (Error messages in Storages are not translated)
       this.alertsServiceProvider
         .get()
         .error(`Could not save page ${page}. Reason: ${errorMessage}`);

diff --git a/skin/src/vue/c-content.vue b/skin/src/vue/c-content.vue
@@ -112,11 +112,8 @@ onUpdated(() => {
     <template #doc-page-actions>
       <div class="doc-page-actions">
         <router-link
-          :to="
-            currentPageRevision || !currentPage?.canEdit
-              ? ''
-              : { name: 'edit', params: { page: currentPageName } }
-          "
+          v-if="!currentPageRevision && currentPage?.canEdit"
+          :to="{ name: 'edit', params: { page: currentPageName } }"
         >
           <x-btn
             size="small"