fix: Select should show selected icon when value is '' (react-compone…

…nt#847) close ant-design/ant-design#38150
xulingling0 · Oct 22, 2022 · 34903a8 · 34903a8
1 parent eefb3e9
commit 34903a8
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/OptionList.tsx b/src/OptionList.tsx
@@ -120,7 +120,7 @@ const OptionList: React.ForwardRefRenderFunction<RefOptionListProps, OptionListP
   // https://github.com/ant-design/ant-design/issues/34975
   const isSelected = React.useCallback(
     (value: RawValueType) => rawValues.has(value) && mode !== 'combobox',
-    [mode, [...rawValues].toString()],
+    [mode, [...rawValues].toString(), rawValues.size],
   );
 
   // Auto scroll to item position in single mode

diff --git a/tests/Multiple.test.tsx b/tests/Multiple.test.tsx
@@ -600,5 +600,25 @@ describe('Select.Multiple', () => {
       expect(errSpy).not.toHaveBeenCalled();
       errSpy.mockRestore();
     });
+
+    it('selected icon should show when value is empty', () => {
+      const wrapper = mount(
+        <Select
+          mode="multiple"
+          open
+          options={[
+            {
+              label: 'Bamboo',
+              value: '',
+            },
+          ]}
+        />,
+      );
+      toggleOpen(wrapper);
+      selectItem(wrapper, 0);
+      expect(wrapper.find('.rc-select-item-option-state-icon').at(0).text()).toBe('✓');
+      selectItem(wrapper, 0);
+      expect(wrapper.find('.rc-select-item-option-state-icon').at(0).text()).toBe('');
+    });
   });
 });