Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes https://github.com/xtf-cz/xtf/issues/595 #596

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Fixes https://github.com/xtf-cz/xtf/issues/595 #596

merged 1 commit into from
Nov 5, 2024

Conversation

tommaso-borgato
Copy link
Contributor

@tommaso-borgato tommaso-borgato commented Nov 4, 2024 •
edited
Loading

This PR add the option to configure "args" in DeploymentConfig;

E.g.:
image

Please make sure your PR meets the following requirements:

  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is formatted, imports ordered, code compiles and tests are passing
  • Code is self-descriptive and/or documented

@tommaso-borgato tommaso-borgato mentioned this pull request Nov 4, 2024
Closed
@tommaso-borgato
Copy link
Contributor Author

@simkam, @mchoma can you have a look?

@simkam
Copy link
Contributor

simkam commented Nov 4, 2024

It looks good, but please update the commit message to something more descriptive.

@tommaso-borgato tommaso-borgato merged commit fd595bc into master Nov 5, 2024
5 checks passed
@simkam simkam deleted the issues-595 branch November 5, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnovak1 mnovak1 mnovak1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tommaso-borgato @simkam @mnovak1