Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: bypass the sampling parameter skip_special_tokens to vLLM backend #2655

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

zjuyzj
Copy link
Contributor

@zjuyzj zjuyzj commented Dec 11, 2024

Update api/restful_api.py and model/llm/vllm/core.py to pass through sampling parameter skip_special_tokens.

Fixes #2656 .

…I to vLLM backend, in order to support visual grounding task for MLLM like Qwen2-VL.
@XprobeBot XprobeBot added the enhancement New feature or request label Dec 11, 2024
@XprobeBot XprobeBot added this to the v1.x milestone Dec 11, 2024
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 0fd2001 into xorbitsai:main Dec 11, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

支持在对话补全请求中控制是否返回特殊标记
3 participants