Tests and changes.

xomniversex · Aug 20, 2010 · cebc7da · cebc7da
1 parent 321db6c
commit cebc7da
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 28 deletions.
diff --git a/TEST/test.js b/TEST/test.js
@@ -16,6 +16,9 @@ sel = sel.snapshotItem(0);
 
 GM_log(sel);
 
-sel.onchange = function(){alert("foo");}
+/// sel.onchange = function(){alert("foo");}
+
+sel.addEventListener("change", function(){alert("foo");}, false);
+
 
 
diff --git a/TEST/test.user.js b/TEST/test.user.js
@@ -10,12 +10,17 @@
 
 // generic test greasemonkey script
 
+GM_log("Script called!");
+
 sel = document.evaluate('//select',
  document, null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null);
 sel = sel.snapshotItem(0);
 
 GM_log(sel);
 
-sel.onchange = function(){alert("foo");}
+/// sel.onchange = function(){alert("foo");}
+
+sel.addEventListener("change", function(){alert("foo");}, false);
+
 
 
diff --git a/bc-log-die-rolls.js b/bc-log-die-rolls.js
@@ -3,7 +3,7 @@
 // @namespace http://conquerclub.barrycarter.info/
 // @description Logs all conquerclub.com die rolls to central server
 // intentionally not putting http below, I want to match files too
-// @include *conquerclub*
+// @include *
 // ==/UserScript==
 
 // HACK: currently, conquerclub doesn't tell you if someone attacks
@@ -14,24 +14,14 @@
 // TODO: how does auto-assault behave?
 // only invoke this script when someone hits 'assault'
 
-function alrt2() {alert('whee');}
-function alrt(x) {alert(x);}
-
-// test
-sel = document.evaluate('//select',
- document, null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null);
-sel = sel.snapshotItem(0);
-
-GM_log(sel);
-
-sel.onchange = function(){alert("foo");}
+GM_log("script called");
 
 // find the button
 button = document.evaluate('//input[@type="submit"][@value="Assault"]',
  document, null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null);
 
 // and link it to function
-// button.snapshotItem(0).addEventListener("click", function() {alert("whee");})
+button.snapshotItem(0).addEventListener("click", logroll, false);
 
 // TODO: production include is: http://www.conquerclub.com/game.php?game=*
 
@@ -43,6 +33,8 @@ button = document.evaluate('//input[@type="submit"][@value="Assault"]',
 
 function logroll() {
 
+GM_log("logroll called");
+
 // TODO: change this URL
 var url = "http://ns1.conquerdata.barrycarter.info/rec.php?v=1";
 

diff --git a/bc-log-die-rolls.user.js b/bc-log-die-rolls.user.js
@@ -3,7 +3,7 @@
 // @namespace http://conquerclub.barrycarter.info/
 // @description Logs all conquerclub.com die rolls to central server
 // intentionally not putting http below, I want to match files too
-// @include *conquerclub*
+// @include *
 // ==/UserScript==
 
 // HACK: currently, conquerclub doesn't tell you if someone attacks
@@ -14,24 +14,14 @@
 // TODO: how does auto-assault behave?
 // only invoke this script when someone hits 'assault'
 
-function alrt2() {alert('whee');}
-function alrt(x) {alert(x);}
-
-// test
-sel = document.evaluate('//select',
- document, null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null);
-sel = sel.snapshotItem(0);
-
-GM_log(sel);
-
-sel.onchange = function(){alert("foo");}
+GM_log("script called");
 
 // find the button
 button = document.evaluate('//input[@type="submit"][@value="Assault"]',
  document, null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null);
 
 // and link it to function
-// button.snapshotItem(0).addEventListener("click", function() {alert("whee");})
+button.snapshotItem(0).addEventListener("click", logroll, false);
 
 // TODO: production include is: http://www.conquerclub.com/game.php?game=*
 
@@ -43,6 +33,8 @@ button = document.evaluate('//input[@type="submit"][@value="Assault"]',
 
 function logroll() {
 
+GM_log("logroll called");
+
 // TODO: change this URL
 var url = "http://ns1.conquerdata.barrycarter.info/rec.php?v=1";