Small tweaks to tests and classes (#321)

* update to take API instead of client options * update android bridge to be v3 only * fix up the tests
xmtp · Nov 8, 2024 · d71c74f · d71c74f
1 parent 912714b
commit d71c74f
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 8 deletions.
diff --git a/library/src/androidTest/java/org/xmtp/android/library/ClientTest.kt b/library/src/androidTest/java/org/xmtp/android/library/ClientTest.kt
@@ -55,7 +55,7 @@ class ClientTest {
             appContext = context,
             dbEncryptionKey = key
         )
-        val inboxId = runBlocking { Client.getOrCreateInboxId(options, fakeWallet.address) }
+        val inboxId = runBlocking { Client.getOrCreateInboxId(options.api, fakeWallet.address) }
         val client = runBlocking {
             Client().create(
                 account = fakeWallet,

diff --git a/library/src/androidTest/java/org/xmtp/android/library/ConversationsTest.kt b/library/src/androidTest/java/org/xmtp/android/library/ConversationsTest.kt
@@ -190,16 +190,15 @@ class ConversationsTest {
             boClient.conversations.sync()
         }
         val boDm = runBlocking { boClient.findConversation(dm.id) }
-        alixClient.dropLocalDatabaseConnection()
-        alixClient.deleteLocalDatabase()
 
         val alixClient2 = runBlocking {
             Client().create(
                 account = alixWallet,
                 options = ClientOptions(
                     ClientOptions.Api(XMTPEnvironment.LOCAL, false),
                     appContext = context,
-                    dbEncryptionKey = key
+                    dbEncryptionKey = key,
+                    dbDirectory = context.filesDir.absolutePath.toString()
                 )
             )
         }

diff --git a/library/src/main/java/org/xmtp/android/library/Client.kt b/library/src/main/java/org/xmtp/android/library/Client.kt
@@ -58,11 +58,11 @@ class Client() {
             registry
         }
 
-        suspend fun getOrCreateInboxId(options: ClientOptions, address: String): String {
+        suspend fun getOrCreateInboxId(environment: ClientOptions.Api, address: String): String {
             var inboxId = getInboxIdForAddress(
                 logger = XMTPLogger(),
-                host = options.api.env.getUrl(),
-                isSecure = options.api.isSecure,
+                host = environment.env.getUrl(),
+                isSecure = environment.isSecure,
                 accountAddress = address
             )
             if (inboxId.isNullOrBlank()) {
@@ -101,7 +101,7 @@ class Client() {
         signingKey: SigningKey? = null,
     ): Client {
         val accountAddress = address.lowercase()
-        val inboxId = getOrCreateInboxId(clientOptions, accountAddress)
+        val inboxId = getOrCreateInboxId(clientOptions.api, accountAddress)
 
         val (ffiClient, dbPath) = createFfiClient(
             accountAddress,

diff --git a/library/src/main/java/org/xmtp/android/library/Conversation.kt b/library/src/main/java/org/xmtp/android/library/Conversation.kt
@@ -112,6 +112,13 @@ sealed class Conversation {
         }
     }
 
+    suspend fun publishMessages() {
+        return when (this) {
+            is Group -> group.publishMessages()
+            is Dm -> dm.publishMessages()
+        }
+    }
+
     val client: Client
         get() {
             return when (this) {