Add some missing field readers to XFontStruct #88
Conversation
| @@ -35,7 +37,7 @@ module Graphics.X11.Xlib.Font( | |||
| import Graphics.X11.Types | |||
| import Graphics.X11.Xlib.Types | |||
|
|
|||
| import Foreign (Ptr, Int32, alloca, allocaBytes, peekByteOff, Word16, #{type unsigned long}, peek, throwIfNull) | |||
| import Foreign (Ptr, Int32, alloca, allocaBytes, peekByteOff, Word16, #{type unsigned long}, peek, plusPtr, throwIfNull) | |||
There was a problem hiding this comment.
I don't see plusPtr being used?
There was a problem hiding this comment.
It seems that plusPtr is used at expanded code of ptr directive.
When plusPtr is dropped, following compile error has occurred.
Graphics/X11/Xlib/Font.hsc:121:47: error:
• Variable not in scope:
plusPtr :: Ptr FontStruct -> t1 -> Ptr CharStruct
• Perhaps you want to add ‘plusPtr’ to the import list
in the import of ‘Foreign’ (Graphics/X11/Xlib/Font.hsc:40:1-96).
|
121 | peekCharStruct $ #{ptr XFontStruct,min_bounds} fs
|
|
Looks like the failures are because of hvr's PPA. On the one hand, we could fix the references; on the other, it's well past time to stop relying on it and switch to ghcup. @liskin? |
|
I think we just use what |
When that's merged we'll still get failures with 7.10 I believe, which we still support because of #80. It's been 2 years since that issue was filed so I guess we can drop support for GHC < 8, we just need to remember to bump the |
Hello, this PR adds the reader functions which seems to be missing.