Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/load from zip #80

Open
wants to merge 111 commits into
base: feat/load_from_zip
Choose a base branch
from

Conversation

ComicallyNormal
Copy link

Hi. I am working on a project downstream of this sdk, that would need to utilize loading from an xmind file and interpreting data from it. Specifically, we will be using trees that will be compared against a valid schema, using custom markers to validate that nodes are at the level in the tree that they are supposed to be at.

I have updated the feature branch with code from master, and implemented basic loading functionality for this project. I would like some feedback, especially about any problems that you guys have run into in the past in attempting to implement this functionality.

Please do not merge this immediately, there are some architectural problems ( the biggest of which is that my loading functions are in the Topic class) that I would like to sort out before considering this ready to merge.

Thank you for your time, and apologies if I am approaching this process wrong, this is my first stab really at open source.

danielsss and others added 30 commits June 3, 2020 14:52
…lodash-4.17.19

build(deps): bump lodash from 4.17.15 to 4.17.19
…elliptic-6.5.3

build(deps): bump elliptic from 6.5.2 to 6.5.3
…elliptic-6.5.4

build(deps): bump elliptic from 6.5.3 to 6.5.4
…y18n-4.0.1

build(deps): bump y18n from 4.0.0 to 4.0.1
…handlebars-4.7.7

build(deps): bump handlebars from 4.7.6 to 4.7.7
…lodash-4.17.21

build(deps): bump lodash from 4.17.19 to 4.17.21
…hosted-git-info-2.8.9

build(deps): bump hosted-git-info from 2.8.8 to 2.8.9
zhangzhonghe and others added 27 commits December 11, 2022 21:37
use `cross-env` and `shx` to adapt commands with other platfoms
Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v2.2.1...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [jszip](https://github.com/Stuk/jszip) from 3.7.0 to 3.8.0.
- [Release notes](https://github.com/Stuk/jszip/releases)
- [Changelog](https://github.com/Stuk/jszip/blob/main/CHANGES.md)
- [Commits](Stuk/jszip@v3.7.0...v3.8.0)

---
updated-dependencies:
- dependency-name: jszip
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
…n master branch since putting it on hold. Added basic support for loading files
@danielsss
Copy link
Contributor

Hi. I am working on a project downstream of this sdk, that would need to utilize loading from an xmind file and interpreting data from it. Specifically, we will be using trees that will be compared against a valid schema, using custom markers to validate that nodes are at the level in the tree that they are supposed to be at.

I have updated the feature branch with code from master, and implemented basic loading functionality for this project. I would like some feedback, especially about any problems that you guys have run into in the past in attempting to implement this functionality.

Please do not merge this immediately, there are some architectural problems ( the biggest of which is that my loading functions are in the Topic class) that I would like to sort out before considering this ready to merge.

Thank you for your time, and apologies if I am approaching this process wrong, this is my first stab really at open source.

@ComicallyNormal Yes, you're right that we've tried to implement the feature before and also, there is an issue(#20) which explains why we didn't do that.

To be honest, the core model has been refactored internally, but we didn't make it open-source yet. I'd like to open an extensional branch if you really want this feature.

You also need to maintain or contribute this branch by yourself.

@ComicallyNormal
Copy link
Author

@ComicallyNormal Yes, you're right that we've tried to implement the feature before and also, there is an issue(#20) which explains why we didn't do that.

Is attachment support the main issue here then? is that due to file references in a .xmind archive that are hard to parse, or some other reason?

To be honest, the core model has been refactored internally, but we didn't make it open-source yet. I'd like to open an extensional branch if you really want this feature.

I'm assuming that I will continue to work on the forked repo and submit MRs into the extensional branch then?

You also need to maintain or contribute this branch by yourself.

This is not a problem, just wanted to make you aware of the work I was doing to avoid duplicating the implementatation.

@danielsss
Copy link
Contributor

@ComicallyNormal Yes, you're right that we've tried to implement the feature before and also, there is an issue(#20) which explains why we didn't do that.

Is attachment support the main issue here then? is that due to file references in a .xmind archive that are hard to parse, or some other reason?

To be honest, the core model has been refactored internally, but we didn't make it open-source yet. I'd like to open an extensional branch if you really want this feature.

I'm assuming that I will continue to work on the forked repo and submit MRs into the extensional branch then?

You also need to maintain or contribute this branch by yourself.

This is not a problem, just wanted to make you aware of the work I was doing to avoid duplicating the implementatation.

  1. It isn't only about the attachments. Basically, I need to implement all the features as much as our UI clients, because our client has more features than this SDK(it means that they might load a file containing features that have not been implemented here).

  2. We can easily keep up-to-date with the master branch and release an individual package for you and others who want this feature. Anyway, It's up to you.

Thanks for letting me know what you are doing. Great Job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants