Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.1.1 #885

Merged
merged 3 commits into from
May 16, 2023
Merged

Release v2.1.1 #885

merged 3 commits into from
May 16, 2023

Conversation

maurafortino
Copy link
Contributor

What's included:

#655
** this won't deprecate webpa-common fully from scytale - but will remove the logging and go-kit features from scytale
added zap logger to servicecfg.NewEnvironment to be used in Scytale
added adapter struct to act as an interface so zap logger could be used in certain functions that required the Log interface

@maurafortino maurafortino added the webpa-common archival/deprecation work related to the archival & deprecation of webpa-common label May 12, 2023
@maurafortino maurafortino self-assigned this May 12, 2023
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #885 (233ee4c) into main (467d1b4) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 233ee4c differs from pull request most recent head 8c7f0e9. Consider uploading reports for the commit 8c7f0e9 to get more accurate results

@@            Coverage Diff             @@
##             main     #885      +/-   ##
==========================================
- Coverage   82.23%   82.22%   -0.02%     
==========================================
  Files         138      138              
  Lines        8556     8556              
==========================================
- Hits         7036     7035       -1     
  Misses       1328     1328              
- Partials      192      193       +1     
Flag Coverage Δ
unittests 82.22% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@sonarcloud
Copy link

sonarcloud bot commented May 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@maurafortino maurafortino merged commit 1e85fa6 into main May 16, 2023
@maurafortino maurafortino deleted the release-v2-1-1 branch May 16, 2023 13:01
@denopink denopink restored the release-v2-1-1 branch May 16, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
webpa-common archival/deprecation work related to the archival & deprecation of webpa-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants