Remove & replacewebpa-common/logging &go-kit/log & go-kit/kit/log with uber zap
#705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@johnabass hey john I'm not sure how we envisioned `Enrich` to interact with go-kit sd.Instancer. It's not clear how `Instancer` would enrich logging atm Here's a past note we left behind // Instancer is the go-kit sd.Instancer which sent this event. This instance can be used to enrich // logging via sallust.Enrich.
denopink
added
the
webpa-common archival/deprecation
Vulnerable Libraries (2)
More info on how to fix Vulnerable Libraries in Go. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
|
github isn't updating this pr, going to close and open a new pr to force it to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included:
loggingpackage and replace go-kit/kit/log & go-kit/log withzap#686bookkeepingpackage tests #465closes #686
closes #465
related to #655
dependent on xmidt-org/sallust#39