new port pffft #6058
Merged
new port pffft #6058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it |
waruqi
reviewed
Dec 27, 2024
waruqi
reviewed
Dec 27, 2024
waruqi
reviewed
Dec 27, 2024
waruqi
reviewed
Dec 27, 2024
waruqi
reviewed
Dec 27, 2024
waruqi
reviewed
Dec 27, 2024
waruqi
reviewed
Dec 27, 2024
waruqi
reviewed
Dec 27, 2024
waruqi
reviewed
Dec 27, 2024
waruqi
reviewed
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ x ] Im confused how to deal with option here...
[ ] License itself does not seem into repo. (Like License file is seems to be used to store into conan, and being stored into vcpkg repo itself)...
[ x ] Maybe there is better url to use.
[ ] De-bundle fftpack & if there is need & possible (most likely this is abandoned & modified bundled dependency)? Quite funny to see it still stored there (https://chromium.googlesource.com/chromium/src/+/c1086af075699b05612673ef0005b0d3e0817a04/third_party/pffft/src & here https://healpix.jpl.nasa.gov/html/libfftpack/dirs.html) (Most likely file header stores LICENSE itself.)
If everything is ok feel free to merge, if there is need edit feel free to edit.