Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compose/paths: fix false <-> NULL confusion, errors on C23 #541

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

bluetech
Copy link
Member

Patch authored by Jeffrey Cliff, send by email:

i don't have access to github but this patch enabled me to compile libxkbcommon with -std=gnu23

otherwise the following compilation error will result :

../src/compose/paths.c:70:16: error: incompatible types when returning type ‘_Bool’ but ‘char *’ was expected

( gcc (GCC) 15.0.0 20240509 (experimental) )

i don't have access to github but this patch enabled me to compile
libxkbcommon with -std=gnu23

otherwise the following compilation error will result :

    ../src/compose/paths.c:70:16: error: incompatible types when returning type ‘_Bool’ but ‘char *’ was expected

( gcc (GCC) 15.0.0 20240509 (experimental) )

Signed-off-by: Ran Benita <[email protected]>
@bluetech bluetech merged commit b1b9ff6 into master Nov 23, 2024
4 checks passed
@bluetech bluetech deleted the compose-c23-fix branch November 23, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant