Registry: use safe libxml2 API #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wismill
added
enhancement
|
@nwellnhof I do not see how to get rid of |
wismill
force-pushed
the
registry/use-safe-libxml2-api
branch
from
cd04ea7 to
3f5452e
Compare
|
Yes, we need additional function for parsing and validating against external DTDs that take a parser context. I just created a libxml2 issue: https://gitlab.gnome.org/GNOME/libxml2/-/issues/808 |
Contextual functions are safer because they do not rely on a global state.
wismill
force-pushed
the
registry/use-safe-libxml2-api
branch
from
3f5452e to
8c0cf06
Compare
|
Tested with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #529 and the related comment in the original Gnome issue.