build: Check for --undefined-version support #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wismill
added
bug
whot
approved these changes
Jul 16, 2024
meson.build
Outdated
| have_version_script = cc.links( | ||
| 'int main(){}', | ||
| args: '-Wl,--undefined-version,--version-script=' + meson.current_source_dir()/'xkbcommon.map', | ||
| args: '-Wl,--version-script=' + meson.current_source_dir()/'xkbcommon.map' + extra_linker_args, |
There was a problem hiding this comment.
fwiw, meson has for quite a while supported f-strings so this may be easier as:
Suggested change
| args: '-Wl,--version-script=' + meson.current_source_dir()/'xkbcommon.map' + extra_linker_args, | |
| args: f'-Wl,--version-script=@map@@extra_linker_args@', |
with an extra
map = meson.current_source_dir()/'xkbcommon.map
above somewhere
There was a problem hiding this comment.
@whot Good idea. I raised minimal meson version from 0.52 (October 2019) to 0.58 (May 2021) to enable f-strings.
There was a problem hiding this comment.
Given that #313 updated to a meson version of barely one year old at that time, I guess 3 years old is OK here.
wismill
force-pushed
the
meson/check-linker-arg-undefined-version
branch
from
7d4649e to
7e3244d
Compare
This will enable f-strings and allow us to simplify the build file.
Gate the use of `--undefined-version` in the linker because it breaks on older GNU `ld`: https://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=58272.
wismill
force-pushed
the
meson/check-linker-arg-undefined-version
branch
from
7e3244d to
d0b7108
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gate the use of
--undefined-versionin the linker because it breaks on older GNUld: https://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=58272.Fixes #481
@glechapelain @eli-schwartz