Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

state: Add support for group latch action #483

Merged
merged 1 commit into from
Aug 28, 2024
Merged

state: Add support for group latch action #483

merged 1 commit into from
Aug 28, 2024

Conversation

wismill
Copy link
Member

@wismill wismill commented Jul 4, 2024

Surprisingly, the latch group action was not yet implemented.

Added tests to ensure we get the tricky bits right.

Fixes #455

@wismill wismill force-pushed the groups/latched branch 8 times, most recently from b5b1e3e to 5e8ae76 Compare July 4, 2024 14:54
@wismill
Copy link
Member Author

wismill commented Jul 4, 2024

So, mixing enum and signed int in bit fields turned out to not be portable on Windows, so I replaced the enum field with an explicit unsigned int.

@wismill
Copy link
Member Author

wismill commented Jul 4, 2024

The commit DELETE ME: … is for debugging only and should be removed once the rest is validated.

@wismill wismill requested review from whot and bluetech July 4, 2024 14:57
@wismill wismill added X11 legacy: missing feature Indicates a need to implement legacy X11 features state Indicates a need for improvements or additions to the xkb_state API labels Jul 12, 2024
@wismill wismill mentioned this pull request Jul 12, 2024
Closed
@wismill wismill added this to the 1.8.0 milestone Aug 27, 2024
@wismill
state: Add support for group latch action
a319d32 
Surprisingly, the latch group action was not yet implemented.

Added tests to ensure we get the tricky bits right.
@wismill wismill force-pushed the groups/latched branch 2 times, most recently from 4abbe5a to a319d32 Compare August 28, 2024 15:13
@wismill
Copy link
Member Author

wismill commented Aug 28, 2024

Quite confident on this one given the tests. Merging

@wismill wismill merged commit e9bd7de into xkbcommon:master Aug 28, 2024
4 checks passed
@wismill wismill deleted the groups/latched branch September 27, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whot whot Awaiting requested review from whot

@bluetech bluetech Awaiting requested review from bluetech

Assignees
No one assigned
Labels
state Indicates a need for improvements or additions to the xkb_state API X11 legacy: missing feature Indicates a need to implement legacy X11 features
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

LatchGroup action is not supported
1 participant
@wismill