Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interactive-evdev: reduce the space allocated for keysyms #443

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

whot
Copy link
Contributor

@whot whot commented Feb 7, 2024

In commit 8cca3a7 the buffer for the keysym was extended to accommodate for up to XKB_COMPOSE_MAX_STRING_SIZE bytes. This caused the printf to expand to the same width for the keysym alone, making the output less useful. Drop this back down to the same width it was before.

cc @wismill

In commit 8cca3a7 the buffer for the keysym
was extended to accommodate for up to XKB_COMPOSE_MAX_STRING_SIZE bytes. This
caused the printf to expand to the same width for the keysym alone, making the
output less useful. Drop this back down to the same width it was before.
@wismill wismill added this to the 1.7.0 milestone Feb 8, 2024
Copy link
Member

@wismill wismill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

tools/tools-common.c Outdated Show resolved Hide resolved
@wismill wismill merged commit dd3e214 into xkbcommon:master Feb 8, 2024
4 checks passed
wismill pushed a commit to wismill/libxkbcommon that referenced this pull request Dec 16, 2024
)

* interactive-evdev: reduce the printed space used for keysyms

In commit 8cca3a7 the buffer for the keysym
was extended to accommodate for up to XKB_COMPOSE_MAX_STRING_SIZE bytes. This
caused the printf to expand to the same width for the keysym alone, making the
output less useful. Drop this back down to the same width it was before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants