registry: Parse “popularity” attribute #406
Conversation
wismill
added
bug
There was a problem hiding this comment.
side-note: the reason I skipped this in the registry loading is because at the time xkeyboard-config didn't always set it (iirc) and it's somewhat superfluous since xk-c also guarantees that there's no exotic in the default base.xml file, see the test_rules.py there.
A few style nitpicks but this LGTM to me otherwise. The struct config_item change would be nice if you find the time for it.
wismill
force-pushed
the
registry/popularity
branch
3 times, most recently
from
4cb6e5f to
ee9be77
Compare
| l->popularity = popularity; | ||
| l->description = config.description; | ||
| l->brief = config.brief; | ||
| l->popularity = config.popularity; |
There was a problem hiding this comment.
we totally need a g_steal_pointer or copy libei's steal macro for the same effect. would allow us to just use an unconditional cleanup path.
There was a problem hiding this comment.
I will have a look, but let’s do this in another PR.
There was a problem hiding this comment.
I gave it a try in #407.
Previously the attribute “popularity” was completely ignored. It also did not respect the modified DTD, because its default value depends if we are currently parsing an “extras” rules file. Fixed: - Always parse the popularity attribute. - Change the DTD to reflect that the default value is implied.
wismill
force-pushed
the
registry/popularity
branch
from
ee9be77 to
3189816
Compare
Previously the attribute “popularity” was completely ignored. It also did not respect the modified DTD, because its default value depends if we are loading an “extras” rules file.
Fixed:
Fixes #278