Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip heading UTF-8 encoded BOM #394

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Skip heading UTF-8 encoded BOM #394

merged 3 commits into from
Oct 30, 2023

Conversation

wismill
Copy link
Member

@wismill wismill commented Oct 29, 2023

Fixes #393

@wismill wismill mentioned this pull request Oct 29, 2023
Closed
@wismill wismill marked this pull request as ready for review October 29, 2023 07:02
@wismill wismill requested review from whot and bluetech October 29, 2023 07:02
whot
whot approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@whot whot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

test/data/rules/bom Outdated Show resolved Hide resolved
@wismill
Copy link
Member Author

wismill commented Oct 30, 2023

Review fixes & improved commit messages.

@wismill
Compose: skip heading UTF-8 encoded BOM (U+FEFF)
adef374 
Leading BOM is legal and is used as a signature — an indication that
an otherwise unmarked text file is in UTF-8.
See: https://www.unicode.org/faq/utf_bom.html#bom5 for further details.
@wismill
xkbcomp: skip heading UTF-8 encoded BOM (U+FEFF)
8d66817 
Leading BOM is legal and is used as a signature — an indication that
an otherwise unmarked text file is in UTF-8.
See: https://www.unicode.org/faq/utf_bom.html#bom5 for further
details.
@wismill
rules: skip heading UTF-8 encoded BOM (U+FEFF)
a1cc806 
Leading BOM is legal and is used as a signature — an indication that
an otherwise unmarked text file is in UTF-8.
See: https://www.unicode.org/faq/utf_bom.html#bom5 for further details.
@wismill wismill merged commit 9e88718 into xkbcommon:master Oct 30, 2023
4 checks passed
@wismill wismill deleted the parser/skip-BOM branch October 30, 2023 06:18
@wismill wismill mentioned this pull request Oct 30, 2023
Merged
@wismill wismill added this to the 1.7.0 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whot whot whot approved these changes

@bluetech bluetech Awaiting requested review from bluetech

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

xkbcommon chokes on UTF-8 BOM
2 participants
@wismill @whot