Improve compose traverse perf #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wismill
added
compose
wismill
force-pushed
the
compose/traverse-perf
branch
2 times, most recently
from
787f16f to
1bd744d
Compare
wismill
force-pushed
the
compose/traverse-perf
branch
2 times, most recently
from
279ad2f to
b59bdc9
Compare
wismill
force-pushed
the
compose/traverse-perf
branch
2 times, most recently
from
80679a0 to
a26a5a2
Compare
|
Rebased, added quickcheck test against |
wismill
force-pushed
the
compose/traverse-perf
branch
2 times, most recently
from
c9b6670 to
454f65e
Compare
|
Rebased, improved comments and added roundtrip test. Will merge soon. |
wismill
force-pushed
the
compose/traverse-perf
branch
from
454f65e to
72e18d4
Compare
- Move `print_compose_table_entry` to own file and add a `file` argument to select output. - Add `xkb_compose_table_dump` to dump a Compose table. This change is needed in order to share the feature “dump a Compose table” between tests and tools.
Test against the `foreach` reference implementation: - Suffle compose file lines randomly; - Compare traversal entry by entry. The `foreach` Compose traversal implementation is based on Ran’s work: bluetech@f7f3c3c
This allow us to compare the iterator API to the fastest implementation, `foreach`.
New implementation without explicit direction
wismill
force-pushed
the
compose/traverse-perf
branch
from
72e18d4 to
582d68b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #367 (see the motivation). The aim is to explore better implementations of the compose traversal API, in particular
xkb_compose_table_iterator_next.Currently it is in the state of #367 before removing alternative implementation and squashing. It will need to be rebased once #367 is merged.DoneI kept the 2 implementations (see the benchmarks) in an intermediate commit for testing.
TODO: