Remove xkb_compose_table_iterator_current

xkbcommon · Sep 25, 2023 · a27b66c · a27b66c
1 parent 669f269
commit a27b66c
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 26 deletions.
diff --git a/bench/compose-traversal.c b/bench/compose-traversal.c
@@ -50,6 +50,7 @@ main(void)
     FILE *file;
     struct xkb_compose_table *table;
     struct xkb_compose_table_iterator *iter;
+    struct xkb_compose_table_entry *entry;
     struct bench bench;
     char *elapsed;
 
@@ -81,8 +82,8 @@ main(void)
         xkb_compose_table_for_each(table, compose_fn, NULL);
 #else
         iter = xkb_compose_table_iterator_new(table);
-        while (xkb_compose_table_iterator_next(iter)) {
-            assert (xkb_compose_table_iterator_current(iter));
+        while ((entry = xkb_compose_table_iterator_next(iter))) {
+            assert (entry);
         }
         xkb_compose_table_iterator_free(iter);
 #endif

diff --git a/include/xkbcommon/xkbcommon-compose.h b/include/xkbcommon/xkbcommon-compose.h
@@ -427,8 +427,8 @@ struct xkb_compose_table_iterator;
  *
  * ```c
  * struct xkb_compose_table_iterator *iter = xkb_compose_table_iterator_new(compose_table);
- * while (xkb_compose_table_iterator_next(iter)) {
- *     struct xkb_compose_table_entry * entry = xkb_compose_table_iterator_current(iter);
+ * struct xkb_compose_table_entry *entry;
+ * while (entry = xkb_compose_table_iterator_next(iter)) {
  *     // ...
  * }
  * xkb_compose_table_iterator_free(iter);
@@ -452,18 +452,6 @@ xkb_compose_table_iterator_new(struct xkb_compose_table *table);
 void
 xkb_compose_table_iterator_free(struct xkb_compose_table_iterator *iter);
 
-/**
- * Return the current entry of a compose table iterator.
- *
- * Once the iterator reaches the last entry, this function will keep
- * returning this entry.
- *
- * @memberof xkb_compose_table_iterator
- * @since 1.6.0
- */
-struct xkb_compose_table_entry *
-xkb_compose_table_iterator_current(struct xkb_compose_table_iterator *iter);
-
 /**
  * Get the next compose entry from a compose table iterator.
  *

diff --git a/src/compose/table.c b/src/compose/table.c
@@ -368,12 +368,6 @@ xkb_compose_table_iterator_free(struct xkb_compose_table_iterator *iter)
     free(iter);
 }
 
-XKB_EXPORT struct xkb_compose_table_entry *
-xkb_compose_table_iterator_current(struct xkb_compose_table_iterator *iter)
-{
-    return &iter->entry;
-}
-
 XKB_EXPORT struct xkb_compose_table_entry *
 xkb_compose_table_iterator_next(struct xkb_compose_table_iterator *iter)
 {

diff --git a/tools/compose.c b/tools/compose.c
@@ -167,10 +167,10 @@ main(int argc, char *argv[])
         }
     }
 
-
     struct xkb_compose_table_iterator *iter = xkb_compose_table_iterator_new(compose_table);
-    while (xkb_compose_table_iterator_next(iter)) {
-        print_compose_table_entry(xkb_compose_table_iterator_current(iter));
+    struct xkb_compose_table_entry *entry;
+    while ((entry = xkb_compose_table_iterator_next(iter))) {
+        print_compose_table_entry(entry);
     }
     xkb_compose_table_iterator_free(iter);
 

diff --git a/xkbcommon.map b/xkbcommon.map
@@ -117,7 +117,6 @@ global:
     xkb_compose_table_entry_utf8;
     xkb_compose_table_iterator_new;
     xkb_compose_table_iterator_free;
-    xkb_compose_table_iterator_current;
     xkb_compose_table_iterator_next;
     // [FIXME] remove
 	xkb_compose_table_for_each;