Add stdout and stderr logging for AV2. #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negge
requested changes
Apr 9, 2021
| @@ -250,7 +250,7 @@ av2 | av2-ai | av2-ra | av2-ra-st | av2-ld | av2-as) | |||
| echo "#!/bin/bash" > /tmp/enc$$.sh | |||
| echo "TIMER='time -v --output='enctime$$-\$1.out" >> /tmp/enc$$.sh | |||
| echo "RUN='$AOMENC --codec=av1 --cq-level=$x --test-decode=fatal $CTC_PROFILE_OPTS -o $BASENAME-'\$1'.obu $EXTRA_OPTIONS --limit=130 --'\$1'=65 $FILE'" >> /tmp/enc$$.sh | |||
| echo "\$(\$TIMER \$RUN > $BASENAME$$-stdout.txt)" >> /tmp/enc$$.sh | |||
| echo "\$(\$TIMER \$RUN > $BASENAME$$-stdout.txt 2> $BASENAME$$-stderr.txt)" >> /tmp/enc$$.sh | |||
There was a problem hiding this comment.
Doesn't
It looks like the files are copied back, but they will still contain the PID and not easily linkable from the AWCY frontend. Are these merged somewhere?
There was a problem hiding this comment.
No, they shouldn't contain the PID? However, they don't actually get merged properly. Both of those should probably be >> for mt.
There was a problem hiding this comment.
The $$ in those file names is the PID. I don't think you want to use >> as that would interleave the output. Instead, after both have completed, you should merge these into a single file before copying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.