Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bert fix2 #6

Open
wants to merge 82 commits into
base: merged_bert
Choose a base branch
from
Open

Bert fix2 #6

wants to merge 82 commits into from

Conversation

xinhaoc
Copy link
Owner

@xinhaoc xinhaoc commented Sep 25, 2024

Description of changes:

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

  • Closes #

Before merging:

  • Did you update the flexflow-third-party repo, if modifying any of the Cmake files, the build configs, or the submodules?

Teresa Noyola and others added 30 commits April 17, 2023 17:46
push changes to print dot graph
2436152
padded input to 512, added isExact to slice_tensor
7030ae0
@lockshaw
Add multiprecision support to replicate
280d29a
@lockshaw
Add explicit template instantiations for replicate kernels
8e84401
@lockshaw
Fix incorrect instantiations
a2ddb91
@lockshaw
Add nop init_task for replicate
52cc8e8
@lockshaw
Fix replicate init_task registration
9eb530a
@lockshaw
Hopefully print hip errors
d7a219c
@lockshaw
Instantiate extra hip replicate kernels
f323a6e
@jiazhihao
fix
9a75f24
@jiazhihao
Merge branch 'BertMLM_fixes' of https://github.com/flexflow/FlexFlow …
fe61cbe 
…into BertMLM_fixes
@jiazhihao
debug changs
c9277f3
Add slice_tensor fix
fe66561
Merge branch 'BertMLM_fixes' of github.com:flexflow/FlexFlow into Ber…
9e04302 
…tMLM_fixes
@lockshaw
Add logging for metrics
1177748
@lockshaw
Add the cuda metrics hack to hip kernel as well
5b7cace
@lockshaw
Add parallel dim pretty printing
e798a91
@jiazhihao
[Embedding] bug fix
90541cf
@jiazhihao
Merge branch 'BertMLM_fixes' of https://github.com/flexflow/FlexFlow …
63fcde6 
…into BertMLM_fixes
@lockshaw
Add replica dim to pretty print
7862143
@lockshaw
Merge remote-tracking branch 'refs/remotes/origin/BertMLM_fixes' into…
9663d96 
… BertMLM_fixes
@tnoyola
Fix replicate issue with python hack
ef43c36
@lockshaw
Use local json submodule
dd8090e
ofi conduit-related fixes
0dc6187
@lockshaw
Add mpi flags for hip
0950ac7
@jiazhihao
fix fusion bug
4b06040
@jiazhihao
Merge branch 'BertMLM_fixes' of https://github.com/flexflow/FlexFlow …
6796b1c 
…into BertMLM_fixes
@jiazhihao
increase the max number of regions in a ZeroInitMeta from 64 to 128
99e9f95
@jiazhihao
support mixed precision
282c44a
@jiazhihao
undo changes to Fused::Transpose
992dcb9
suranap
suranap reviewed Sep 26, 2024
View reviewed changes
deps/legion Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is the right version of Legion? Looks like you used the old version of Legion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suranap suranap suranap left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xinhaoc @suranap @lockshaw @jiazhihao @tnoyola @goliaro