fix: panic when the ip network has no mask

xgfone · Jan 21, 2019 · df8cbe4 · df8cbe4
1 parent 9d64b16
commit df8cbe4
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/ipnet.go b/ipnet.go
@@ -289,6 +289,7 @@ func NewIPNetwork(ipnet string) (IPNetwork, error) {
 	var mask int
 	index := strings.IndexByte(ipnet, '/')
 	if index == -1 {
+		index = len(ipnet)
 		if strings.IndexByte(ipnet, ':') == -1 {
 			mask = 32
 		} else {

diff --git a/ipnet_test.go b/ipnet_test.go
@@ -16,8 +16,21 @@ package netaddr
 
 import (
 	"fmt"
+	"testing"
 )
 
+func TestNewIPNetwork(t *testing.T) {
+	net := MustNewIPNetwork("192.168.10.10/24")
+	if net.String() != "192.168.10.10/24" {
+		t.Error(net.String())
+	}
+
+	net = MustNewIPNetwork("192.168.10.10")
+	if net.String() != "192.168.10.10/32" {
+		t.Error(net.String())
+	}
+}
+
 func ExampleIPNetwork_Network() {
 	net := MustNewIPNetwork("192.168.10.10/24")
 	fmt.Println(net.Network())