-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude packages from runtime proxy generation #46
base: master
Are you sure you want to change the base?
Conversation
For things other than nit fix, I think a PR will make things clear about what have changed. |
db6feda
to
e989cfa
Compare
Now we wait for the patch get merged. |
Hi, This library doesn't seem to play nice with LeakCanary. It attempts to create a I think your processor code should probably check if a class is "final" before attempting to do stuff with it. Adding "com.squareup.leakcanary.internal.DisplayLeakConnectorView" to the "excludePackages" list doesn't seem to work either. I think it would be nicer if the excludePackages entries were regex based, therefore removing the need to explicitly list every possible Views within a given package in the gradle file. Do you mind isolating the resValue changes from the PR (as that's a new feature as far as I'm aware and we don't know how long google devs might take to merge your change in) and merging the bug fixes in so that we can test the fix on our apps? |
Automatically filtering out final views is an issue I afraid I don't have time to deal with because for the following several months I have to prepare for job interviews (:disappointed:). But hey, PRs are always welcome! |
Aah no worries dude, good luck with the interviews. All I need is IntelliJ idea right? No extra libraries/tool required. |
Yep. Go nuts! 👍 |
To work with LeakCanary:
|
@mikeyxkcd The package exclusion will skip views that starts with the given path. I don't think we need to make it regex based. |
Fixes #32 #48