Fix when manifestSrc contains a Shared Access Key #1735
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a problem today, the manifestSrc url contains a Shared Access Key (files are not public avialable) and the key contained a /.
Example:
https://domain.com/manifest.json?sp=r&sig=/eDdWelJCWXFUnBrPdkyuvGW5b4VIvhfhHSg844pGsQ%3D
In this case the signature contains a /, this causes the function
getBaseDirectory
to get the wrong base path.Solution: strip the querystring from the filePath