Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when manifestSrc contains a Shared Access Key #1735

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

mlankamp
Copy link
Contributor

Ran into a problem today, the manifestSrc url contains a Shared Access Key (files are not public avialable) and the key contained a /.

Example: https://domain.com/manifest.json?sp=r&sig=/eDdWelJCWXFUnBrPdkyuvGW5b4VIvhfhHSg844pGsQ%3D

In this case the signature contains a /, this causes the function getBaseDirectory to get the wrong base path.

Solution: strip the querystring from the filePath

@xeolabs xeolabs merged commit 463e378 into xeokit:master Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants