Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Return string instead of void to DistanceMeasurementsPlugin's subscribers #1245

Merged
merged 1 commit into from
Nov 18, 2023
Merged

FIX: Return string instead of void to DistanceMeasurementsPlugin's subscribers #1245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions types/plugins/DistanceMeasurementsPlugin/DistanceMeasurementsPlugin.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,27 +123,27 @@ export declare class DistanceMeasurementsPlugin extends Plugin {
* @param {String} event The measurementCreated event
* @param {Function} callback Callback fired on the event
*/
on(event: "measurementCreated", callback: (measurement: DistanceMeasurement)=> void): void;
on(event: "measurementCreated", callback: (measurement: DistanceMeasurement)=> void): string;

/**
* Fires when a measurement is completed.
* @param {String} event The measurementEnd event
* @param {Function} callback Callback fired on the event
*/
on(event: "measurementEnd", callback: (measurement: DistanceMeasurement)=> void): void;
on(event: "measurementEnd", callback: (measurement: DistanceMeasurement)=> void): string;

/**
* Fires when a measurement is cancelled.
* @param {String} event The measurementCancel event
* @param {Function} callback Callback fired on the event
*/
on(event: "measurementCancel", callback: (measurement: DistanceMeasurement)=> void): void;
on(event: "measurementCancel", callback: (measurement: DistanceMeasurement)=> void): string;

/**
* Fires when a measurement is destroyed.
* @param {String} event The measurementDestroyed event
* @param {Function} callback Callback fired on the event
*/
on(event: "measurementDestroyed", callback: (measurement: DistanceMeasurement)=> void): void;
on(event: "measurementDestroyed", callback: (measurement: DistanceMeasurement)=> void): string;

}