Fixes 0 stride handling #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7oxicshadow
added a commit
to 7oxicshadow/xemu
that referenced
this pull request
Feb 1, 2022
early merge xemu-project#688 initial test support for VMU
abaire
force-pushed
the
fixes_0_stride_handling
branch
2 times, most recently
from
60340e2 to
60c5417
Compare
abaire
force-pushed
the
fixes_0_stride_handling
branch
from
60c5417 to
f1399bc
Compare
mborgerson
reviewed
Mar 20, 2022
| pgraph_update_inline_value(attr, last_entry); | ||
| glDisableVertexAttribArray(i); | ||
| glVertexAttrib4fv(i, attr->inline_value); | ||
| continue; |
There was a problem hiding this comment.
As written, this continue is unnecessary. However, we could also move this last entry update block up and eliminate some GL calls in the process (i.e. we don't need to set attrib pointer and enable it just to then disable it)
abaire
force-pushed
the
fixes_0_stride_handling
branch
from
f1399bc to
4ce20dd
Compare
mborgerson
force-pushed
the
fixes_0_stride_handling
branch
from
4ce20dd to
877d509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special cases attributes with stride = 0 by using the first value in the buffer for all vertices, matching hardware.
Test case
Results
Fixes #686
Fixes #174