ui: Handle snapshots with empty names in snapshot menu #1547
+88
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antangelo
force-pushed
the
ui/snapshot-empty-name
branch
from
acc8f10 to
41cda47
Compare
antangelo
force-pushed
the
ui/snapshot-empty-name
branch
from
41cda47 to
58e4d91
Compare
|
Should we just prevent creating snapshots with the empty string as the name? This seems like a lot of work to handle this weird case |
|
We can prevent them from being created within xemu, but that won't cover existing empty-name snapshots or those created by qemu-img (which are also niche cases). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshots without names are somewhat difficult to create (must use
savevm ""in the monitor, QMP, or qemu-img) but should be handled correctly regardless.This requires adding an additional present bool to the config. I preserved compatibility with existing shortcut bindings by checking the present field or that the shortcut snapshot name string is not empty.
Fixes #1543