Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when going to Snapshots settings. #1543

Open
BiatuAutMiahn opened this issue Oct 24, 2023 · 4 comments · May be fixed by #1547
Open

Crash when going to Snapshots settings. #1543

BiatuAutMiahn opened this issue Oct 24, 2023 · 4 comments · May be fixed by #1547
Assignees
@antangelo
Labels
bug Something isn't working

Comments

@BiatuAutMiahn
Copy link

BiatuAutMiahn commented Oct 24, 2023 •
edited
Loading

Bug Description

  1. Launch Xemu
  2. Goto Machine -> Snapshots, or Machine -> (Any Setting Menu) -> Snapshots
  3. Crash.

xemu.toml

[general]
show_welcome = false
screenshot_dir = 'screenshots'
last_viewed_menu_index = 7

[input]
background_input_capture = true

[display.window]
startup_size = '640x480'
last_width = 1707
last_height = 889

[audio]
use_dsp = true

[sys.files]
bootrom_path = 'data\boot.bin'
flashrom_path = 'data\bios.bin'
eeprom_path = 'data\eeprom.bin'
hdd_path = 'data\hdd.qcow2'

Expected Behavior

Open snapshot settings.

xemu Version

...

System Information

...

Additional Context

xemu.log

Created QEMU launch parameters: D:\System\Programs\Xemu\xemu.exe -machine xbox,bootrom=data\boot.bin,kernel-irqchip=off,avpack=hdtv -device smbus-storage,file=data\eeprom.bin -bios data\bios.bin -m 64 -drive index=0,media=disk,file=data\hdd.qcow2,locked=on -drive index=1,media=cdrom,file= -display xemu -device usb-hub,port=1,ports=4 -audiodev none,id=snd0 
xemu_version: 0.7.116
xemu_branch: master
xemu_commit: b3fc80b3a83fa99aeb541a0c665cfb596cedd71c
xemu_date: Sun Oct 22 07:25:29 UTC 2023
xemu_settings_get_base_path: base path: D:\System\Programs\Xemu\
xemu_settings_get_path: config path: D:\System\Programs\Xemu\xemu.toml
Warning: unrecognized key 'input.current_snapshot_binding' at line 8 column 28
CPU: 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz
OS_Version:  23H2
GL_VENDOR: NVIDIA Corporation
GL_RENDERER: NVIDIA GeForce RTX 3080 Laptop GPU/PCIe/SSE2
GL_VERSION: 4.0.0 NVIDIA 472.19
GL_SHADING_LANGUAGE_VERSION: 4.00 NVIDIA via Cg compiler
audio: Device ac97: audiodev default parameter is deprecated, please specify audiodev=snd0
**
ERROR:../ui/xui/main-menu.cc:877:virtual void MainMenuSnapshotsView::Draw(): assertion failed: (current_snapshot_binding == -1)
Bail out! ERROR:../ui/xui/main-menu.cc:877:virtual void MainMenuSnapshotsView::Draw(): assertion failed: (current_snapshot_binding == -1)
@BiatuAutMiahn BiatuAutMiahn added the bug Something isn't working label Oct 24, 2023
@antangelo
Copy link
Contributor

Can you provide a list of snapshots on your disk image? Please run info snapshots in the monitor.

@BiatuAutMiahn
Copy link
Author 

List of snapshots present on all disks:
ID        TAG               VM SIZE                DATE     VM CLOCK     ICOUNT
--                         65.2 MiB 2021-04-15 14:01:00 00:06:56.490           
--        doom3            65.2 MiB 2021-04-15 14:01:32 00:07:27.910

@antangelo
Copy link
Contributor

How did you create the snapshot with no name?

@antangelo antangelo self-assigned this Oct 26, 2023
@BiatuAutMiahn
Copy link
Author

I didn't intentionally, must have been a while ago when I was trying to create snapshots before it was fully implemented.

@antangelo antangelo linked a pull request Oct 26, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antangelo antangelo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: Handle snapshots with empty names in snapshot menu antangelo/xemu
2 participants
@BiatuAutMiahn @antangelo