-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial faces work #132
base: master
Are you sure you want to change the base?
Initial faces work #132
Conversation
rearrange blocks in details view, some polishing
d77c498
to
41d1851
Compare
Hi @dukobpa3 I am happy to announce the first experimental plugin feature in the current master! See docs.home-gallery.org/plugin for further details! |
@dukobpa3 what are the status of this PR? Are you still working on it? |
Have been not working on it for a while. Was a lot of personal and job tasks. And now I see there a lot of conflicts but also new architecture. Will look on it soon :) |
I see the work with plugins should be better with logical parts, but not understand how to do something with UI in this architecture. Any plugin will provide some additional info which should be shown somewhere? How? |
@dukobpa3 welcome back! Awesome that you are continuing. And yes, there are some changes in favor of the plugin system. And also true for UI changes there is no plugin support yet. Only Extractor (server side), Database Builder (server side) and Query (server side and browser) is supported. The UI is missing but I have prototypes and a PoCs. Most probably it will be done via WebComponents which can be hooked to some UI places like the detail view. Up to now there is no discussion or request regarding plugins and I will add them if this changes. We can have discussions about the plugins (architecture) on the discord channel (finally there is one, thanks again ;-) ) |
As soon as your app doesn't have much UI I think each plugin just can't expose couple components like: Any other popups and views I think can be managed from plugin side Something like that 🤷♂️ |
Are you interessted in a UI plugin to finalize the face tagging? If so, I will try to focus on that feature in the next steps. Currently I am looking for a usecase where the UI plugin could be demonstrated. Maybe we can use your feature to implement as pure plugin? Would you be interested? Otherwise you could implement it into the app and it could be extracted later as plugin |
Right now I've just coptpasted "tags" and made "faceTags" beside Not much like this idea, so if there will be some UI plugin system I think everything become cleaner not only in case of faces. |
Update couple icons.
Update years layout
Was:
Became:
Screen.Recording.2024-04-08.at.12.59.13.mov
Clickable names in details view: