Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial faces work #132

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Conversation

dukobpa3
Copy link

@dukobpa3 dukobpa3 commented Apr 8, 2024

Update couple icons.
Screenshot 2024-04-08 at 12 55 33
Screenshot 2024-04-08 at 12 55 40

Update years layout

Was:
Screenshot 2024-04-08 at 12 59 43

Became:

Screen.Recording.2024-04-08.at.12.59.13.mov

Clickable names in details view:
Screenshot 2024-04-08 at 12 55 56

dukobpa3 added 2 commits April 8, 2024 12:53
rearrange blocks in details view,
some polishing
@dukobpa3
Copy link
Author

dukobpa3 commented Apr 8, 2024

Screenshot 2024-04-08 at 14 53 25

@dukobpa3 dukobpa3 force-pushed the feature/face-recognition branch from d77c498 to 41d1851 Compare April 12, 2024 12:08
@xemle
Copy link
Owner

xemle commented Jul 30, 2024

Hi @dukobpa3

I am happy to announce the first experimental plugin feature in the current master! See docs.home-gallery.org/plugin for further details!

@xemle
Copy link
Owner

xemle commented Sep 13, 2024

@dukobpa3 what are the status of this PR? Are you still working on it?

@dukobpa3
Copy link
Author

Have been not working on it for a while. Was a lot of personal and job tasks. And now I see there a lot of conflicts but also new architecture. Will look on it soon :)

@dukobpa3
Copy link
Author

@xemle

I see the work with plugins should be better with logical parts, but not understand how to do something with UI in this architecture. Any plugin will provide some additional info which should be shown somewhere? How?

@xemle
Copy link
Owner

xemle commented Sep 25, 2024

@dukobpa3 welcome back! Awesome that you are continuing.

And yes, there are some changes in favor of the plugin system. And also true for UI changes there is no plugin support yet. Only Extractor (server side), Database Builder (server side) and Query (server side and browser) is supported.

The UI is missing but I have prototypes and a PoCs. Most probably it will be done via WebComponents which can be hooked to some UI places like the detail view.

Up to now there is no discussion or request regarding plugins and I will add them if this changes. We can have discussions about the plugins (architecture) on the discord channel (finally there is one, thanks again ;-) )

@dukobpa3
Copy link
Author

As soon as your app doesn't have much UI I think each plugin just can't expose couple components like:
— main ui button
— under view button
— details panel (like widget which can be added to details view stack)

Any other popups and views I think can be managed from plugin side

Something like that 🤷‍♂️

@xemle
Copy link
Owner

xemle commented Sep 28, 2024

Are you interessted in a UI plugin to finalize the face tagging? If so, I will try to focus on that feature in the next steps.

Currently I am looking for a usecase where the UI plugin could be demonstrated. Maybe we can use your feature to implement as pure plugin? Would you be interested?

Otherwise you could implement it into the app and it could be extracted later as plugin

@dukobpa3
Copy link
Author

Right now I've just coptpasted "tags" and made "faceTags" beside

Not much like this idea, so if there will be some UI plugin system I think everything become cleaner not only in case of faces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants