Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interactive: mlir-gui version 1 #3667

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

interactive: mlir-gui version 1 #3667

wants to merge 13 commits into from

Conversation

dshaaban01
Copy link
Collaborator

This is a first attempt at creating an mlir-gui. I would like to upstream it (still figuring out whether to do that in this repo or in the mlir repo). Open to feedback/advice from anyone interested :)

It is very similar to xdsl-gui, with some changes:

  • only executes mlir-opt --passes , no xdsl-passes
  • displays the list of available mlir-opt passes via parsing the output of `mlir-opt --help' (rather ugly way to get the mlir passes, if I upstream it, will make it more fancy)
  • condense button not there anymore
  • requires mlir-opt to be on your PATH
  • call mlir-gui in terminal to get it :)
Screenshot 2024-12-22 at 16 34 11

Some open questions:

  • should it be connected to xdsl-gui with a button (users can flip between xdsl-gui app and mlir-gui app)?
  • does it belong in the xdsl repo?

Note: It is not perfect and has some errors if you search hard enough (especially with pass selection)! Still needs work, this is just version 1 :)

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.88%. Comparing base (d7f6068) to head (57e8f84).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3667      +/-   ##
==========================================
- Coverage   91.30%   90.88%   -0.42%     
==========================================
  Files         466      468       +2     
  Lines       58357    58626     +269     
  Branches     5624     5651      +27     
==========================================
  Hits        53280    53280              
- Misses       3628     3897     +269     
  Partials     1449     1449              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interactive xdsl-gui things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant