Unhack stencil.store result through bufferization #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapyChacal
force-pushed
the
emilien/coming-soon
branch
2 times, most recently
from
c3b7786 to
a3e3002
Compare
PapyChacal
force-pushed
the
emilien/coming-soon
branch
from
a3e3002 to
5c15ce9
Compare
PapyChacal
changed the title
| @@ -1,4 +1,4 @@ | |||
| // RUN: xdsl-opt -p "distribute-stencil{strategy=3d-grid slices=2,1,1 restrict_domain=false},canonicalize-dmp,convert-stencil-to-ll-mlir" %s | filecheck %s | |||
| // RUN: xdsl-opt -p "canonicalize,cse,distribute-stencil{strategy=3d-grid slices=2,1,1 restrict_domain=false},shape-inference,canonicalize-dmp,stencil-bufferize,dmp-to-mpi{mpi_init=false},convert-stencil-to-ll-mlir,canonicalize,cse" %s | filecheck %s | |||
There was a problem hiding this comment.
This test is doing more than the original one; I think it is stronger, and this is good.
Is there a reason behind that?
There was a problem hiding this comment.
IIRC, canonicalization gets rid of some useless stencil generated operations, that make my bufferization ungracefully fail. (As-in, bufferization expects a canonicalized input)
It could arguably be handled differently but figured might as well add those generic optimizations everywhere; they help with the code and just remove work for heavier optimization passes!
There was a problem hiding this comment.
Thanks for the reply, can you add this (your reply's useful info) as a comment/info/doc in some place you consider it appropriate?
PapyChacal
force-pushed
the
emilien/coming-soon
branch
from
20025ee to
51e6f97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a hacked result on
stencil.store, use astencil.storeand then restencil.load.Use meanwhile added xDSL stuff and update pipelines and tests accordingly!
Filechecks have changed a lot since the pipeline is updated. I took the chance to add more xDSL canonicalization and CSE steps now that it's performing there too!