Adds Video and Image diemensions field in respective class #272
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
himanshu-patel-dev
force-pushed
the
image_video_dimensions_properties
branch
from
07824ed
to
5c07f1d
Compare
Both classes ImageConversationCard and VideoConversationCard have field which have data related to dimensions/size of Video/Image but these fields despite present in API are being dropped/ignored in class properties/attributes, thus consumer of this library can't assess data like 'image_display_height' on ImageConversationCard till now. Current fix enable the same.
himanshu-patel-dev
force-pushed
the
image_video_dimensions_properties
branch
from
5c07f1d
to
aa9120e
Compare
himanshu-patel-dev
changed the title
|
Can maintainers of the librarary provide approval for remaining workflows to trigger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both classes ImageConversationCard and VideoConversationCard have field which have data related to dimensions/size of Video/Image but these fields despite present in API are being dropped/ignored in class properties/attributes, thus consumer of this library can't assess data like 'image_display_height' on ImageConversationCard till now. Current fix enable the same for both Image and Video Conversation Card.
Issue Type: Improvement
Fixes / Relates To: #273
Changes Included:
image_display_heightandimage_display_widthinImageConversationCardclassvideo_widthandvideo_heightinVideoConversationCardclass