Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: Use webcrypto & Uint8Array instead of NodeJS crypto & Buffer #77

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dwardu
Copy link

@dwardu dwardu commented May 29, 2023

Problem

The current auth implementation makes use of NodeJS crypto package and Buffer, and because of this the library cannot be used in contexts where these are unavailable, such as on Cloudflare workers.

Solution

The solution was to replace NodeJS primitives with their standard counterparts.

Result

As a result of the changes in this PR, it will be possible to use the library on environments where NodeJS crypto and Buffer are not available, such as Cloudflare workers.

@CLAassistant
Copy link

CLAassistant commented May 29, 2023

CLA assistant check
All committers have signed the CLA.

@Monneraldo
Copy link

Hi... I want to recover my account. I think I unintentionally broke the Twitter Rules, but after reading it and reading it again well; I undertake not to violate and comply with all laws and policies of use of the Twitter program. I undertake to abide by the laws and thank you for your cooperation

Note I have worked with you a lot on recalculation. Please I want to understand what are your conditions for reinstatement of these accounts mentioned below

👇👇👇👇

@chinanws22

@WORLD___2022

@chinewar111

@dwardu dwardu changed the title auth: Use webcrypto & Uint8Array instead of NodeJS crypto & Buffer Free runtime library from Node.js dependencies May 29, 2023
@dwardu dwardu changed the title Free runtime library from Node.js dependencies auth: Use webcrypto & Uint8Array instead of NodeJS crypto & Buffer May 29, 2023
@clxyder
Copy link

clxyder commented Jul 7, 2024

I can confirm this works as expected, are there any plans to merge this?

@refarer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants