Warn for redundant optionals

xch-dev · Apr 16, 2024 · d31b643 · d31b643
1 parent 6804337
commit d31b643
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/crates/rue-compiler/src/error.rs b/crates/rue-compiler/src/error.rs
@@ -130,6 +130,9 @@ pub enum DiagnosticInfo {
 
     #[error("cannot check equality on non-atom type `{0}`")]
     NonAtomEquality(String),
+
+    #[error("redundant optional type")]
+    RedundantOptional,
 }
 
 /// Join a list of names into a string, wrapped in backticks.

diff --git a/crates/rue-compiler/src/lowerer.rs b/crates/rue-compiler/src/lowerer.rs
@@ -1888,6 +1888,14 @@ impl<'a> Lowerer<'a> {
             .map(|ty| self.compile_type(ty))
             .unwrap_or(self.unknown_type);
 
+        if let Type::Optional(inner) = self.db.ty_raw(ty).clone() {
+            self.warning(
+                DiagnosticInfo::RedundantOptional,
+                optional.syntax().text_range(),
+            );
+            return inner;
+        }
+
         self.db.alloc_type(Type::Optional(ty))
     }