Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS0043 Cover Controller #1082

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ChristopheBraud
Copy link
Contributor

I forgot a commit on my last PR #1076 (sorry)

As I said before, I use Open and Close action rather than toggle actions as there is already a stop button on the controller.
There's also a weird behavior with toggle actions where toggle_open stop a closing action rather than opening the cover.

I suppose this is correct for a two buttons controller, but not for a three buttons one.


Also there is a small mistake in the release notes of v4.28.0:
🎮 New devices

[TS0042](https://xaviml.github.io/controllerx/controllers/TS0042) - add device with ZHA support. [ https://github.com/xaviml/controllerx/pull/1065 ] @Strauman
[TS0043](https://xaviml.github.io/controllerx/controllers/TS0043) - add ZHA support. [ https://github.com/xaviml/controllerx/pull/1066 ] @Strauman
[TS0043](https://xaviml.github.io/controllerx/controllers/TS0043) - add cover controll with ZHA support. [ https://github.com/xaviml/controllerx/pull/1076 ] @ChristopheBraud

Last line should be Z2M, not ZHA. I don't know if you can fix it or not

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95%. Comparing base (ef87f41) to head (eaf9723).
Report is 3 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1082   +/-   ##
====================================
  Coverage    95%     95%           
====================================
  Files        65      65           
  Lines      2713    2713           
====================================
  Hits       2582    2582           
  Misses      131     131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant