Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logo in SVG format #435

Merged
merged 1 commit into from
Mar 17, 2022
Merged

add logo in SVG format #435

merged 1 commit into from
Mar 17, 2022

Conversation

sisp
Copy link
Contributor

@sisp sisp commented Mar 17, 2022

I've created a logo in SVG format by manually re-drawing the PNG one. It isn't pixel-identical:

  • The edges weren't perfectly sharp in the PNG version, so I had to guess the exact coordinates of the path points. The brackets are identical, the right one is the flipped version of the left one. The triangle in the middle is horizontally symmetric, the gaps are exactly parallel to the triangle's line on the left and have identical offsets to their neighbors.
  • The triangle in the middle wasn't perfectly centered vertically and possibly horizontally, but I assumed it should be, so I centered it.
  • I tried to guess the parameters of the gradient by extracting its start and stop color and its angle, but it's not 100% identical to the PNG version.
  • I cropped the canvas so the shape touches the boundaries of the viewport.

I've also updated the PNG version and the favicon, so they are all based on the SVG image.

What do you think?

Related to #433.

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #435 (7bc1ba7) into master (ddfc4de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #435   +/-   ##
=======================================
  Coverage   90.90%   90.90%           
=======================================
  Files         179      179           
  Lines        6389     6389           
  Branches     1157     1168   +11     
=======================================
  Hits         5808     5808           
  Misses        544      544           
  Partials       37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddfc4de...7bc1ba7. Read the comment docs.

@xaviergonz xaviergonz merged commit d2b4834 into xaviergonz:master Mar 17, 2022
@xaviergonz
Copy link
Owner

looks awesome!

@sisp sisp deleted the svg-logo branch March 17, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants