Handle unconvertible CREATE TABLE column defintions
#548
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanslade
approved these changes
Dec 18, 2024
Column storage options are not representable by `pgroll` `Column` definitions.
Column compression options are not representable by `pgroll` `Column` definitions.
Column collation options are not representable by `pgroll` `Column` definitions.
andrew-farries
force-pushed
the
handle-unconvertible-column-defs
branch
from
ecb7433 to
3d33a39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Column definitions in
CREATE TABLEstatements offer several options, most of which aren't currently representable bypgrollColumndefinitions.Add tests and code to ensure that
CREATE TABLEstatements containing columns that use any of these unrepresentable options fall back to raw SQL operations.Part of #504