Use omissis/go-jsonschema image for type generation
#545
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate types from the JSON schema using the `omissis/go-jsonschema` image instead of the `surjection/go-jsonschema` image. We used the `surjection/go-jsonschema` image because we needed a feature that was not yet released in the `omissis/go-jsonschema` image: omissis/go-jsonschema#220 Now that the feature is available in the `omissis/go-jsonschema` `0.17` release we can switch back to using it.
ryanslade
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate types from the JSON schema using the official
omissis/go-jsonschemaimage instead of the customsurjection/go-jsonschemaimage.We built and used the
surjection/go-jsonschemaimage because we needed a feature that was not yet released inomissis/go-jsonschema:omissis/go-jsonschema#220
Now that the feature is available in the
omissis/go-jsonschema0.17release we can switch back to using it.