Add a benchmark for read_schema #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
reviewed
Nov 20, 2024
exekias
reviewed
Nov 20, 2024
| require.NoError(b, mig.Close()) | ||
| }) | ||
|
|
||
| setupInitialTable(b, ctx, testSchema, mig, db, 1) |
There was a problem hiding this comment.
it seems clear that for the shake of this test and the others, we probably want a more complex schema here, right? not for this PR
There was a problem hiding this comment.
Yeah, agree. I'm not sure exactly how the performance of read_schema would change depending on the complexity of the schema but I guess that's something we could actually benchmark too :)
exekias
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a benchmark for the
read_schemafunction which has caused regressions in the past.Part of #408