-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build static HTML page using the latest benchmark results #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ff6c417.
@andrew-farries PTAL, I think this is ready to go now. |
andrew-farries
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a GitHub action to download benchmark data from S3. It then uses a static generator to create charts per benchmark / Postgres version. These results are then bundled up using Jekyll which publishes the README, available at:
https://xataio.github.io/pgroll/
The benchmarks themselves can be see at https://xataio.github.io/pgroll/benchmarks.html (and are also linked from the README)
In order to make this work and also not require users of pgroll as a library to import the charting library we needed to create a new module in
/dev
. We needed to duplicate the definition of the benchmark results structs since we couldn't import them from the mainpgroll
module without actually publishing a new version of the module. Once this module has been published it will be possible.Part of #408