-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android 12 Update and SDK update #237
base: main
Are you sure you want to change the base?
Changes from all commits
1e0b620
67cff4f
eea3d5f
e871c50
f121fe4
fa0091e
421d414
57f3036
6a90ab7
296a107
4727e31
5d1dc04
b6db4bd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
{ | ||
"profiles": { | ||
"WSL": { | ||
"commandName": "WSL2", | ||
"environmentVariables": {}, | ||
"distributionName": "" | ||
}, | ||
"GenParamNames Core": { | ||
"commandName": "Project", | ||
"commandLineArgs": "-o ../facebook-core/transforms/Metadata-Names.xml -i ../../externals/facebook-core-docs/com", | ||
"workingDirectory": "C:\\Dev\\Sources\\Xamarin.FacebookComponents.MOS\\Facebook.Android\\source\\GenParamNames" | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
|
||
<PropertyGroup> | ||
<AndroidCodegenTarget>XAJavaInterop1</AndroidCodegenTarget> | ||
<TargetFramework>MonoAndroid90</TargetFramework> | ||
<TargetFramework>MonoAndroid12.0</TargetFramework> | ||
<IsBindingProject>true</IsBindingProject> | ||
|
||
<AssemblyName>Xamarin.Facebook.AudienceNetwork.Android</AssemblyName> | ||
|
@@ -55,7 +55,7 @@ | |
|
||
<ItemGroup> | ||
|
||
<PackageReference Include="Xamarin.GooglePlayServices.Basement" Version="71.1620.0" PrivateAssets="None" /> | ||
<PackageReference Include="Xamarin.GooglePlayServices.Basement" Version="117.6.0.6" PrivateAssets="None" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this the most recent version, or the version needed by facebook sdk 13? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same question applies to other nuget updates. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The changes were necessary to support Android 12. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suggest to go for the lowest needed to avoid enforcing users to go for the newest version through a transitive dependency. |
||
|
||
</ItemGroup> | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
|
||
<PropertyGroup> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to the dependencies I saw on maven central, there might be some changes. Was made sure, that no adaption to the dependency graph between the C# projects is needed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, I didn't check on this, as the projects built in the same order as before without issues. |
||
<AndroidCodegenTarget>XAJavaInterop1</AndroidCodegenTarget> | ||
<TargetFramework>MonoAndroid90</TargetFramework> | ||
<TargetFramework>MonoAndroid12.0</TargetFramework> | ||
<IsBindingProject>true</IsBindingProject> | ||
|
||
<AssemblyName>Xamarin.Facebook.Android</AssemblyName> | ||
|
@@ -63,6 +63,6 @@ | |
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<PackageReference Include="Xamarin.Kotlin.StdLib.Jdk7" Version="1.5.10" /> | ||
<PackageReference Include="Xamarin.Kotlin.StdLib.Jdk7" Version="1.6.20.1" /> | ||
</ItemGroup> | ||
</Project> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you see additional warnings when building your updated version?
Same question, different way to ask: Are we sure that no modifications to metadata.xml files are needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually yes there are quite a few warnings :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To speed up discussion, feel free to contact me on https://gitter.im