Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pick up seaborn heatmap fmt towards maidr #90

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

dakshpokar
Copy link
Collaborator

@dakshpokar dakshpokar commented Aug 22, 2024

Description

This PR picks up the seaborn heatmap's fmt argument and applies it to the values displayed in maidr. This is done so by passing the argument fmt to the patched heatmap plot.

closes #77

Type of Change

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Pull Request

Description

Related Issues

Changes Made

  1. Parsed the fmt argument from kwargs in the heatmap patch.
  2. Passed the fmt argument in FigureManager's create_maidr function.
  3. Stored the value of fmt, which helps to format the values to display

Screenshots (if applicable)

image

Checklist

  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code and ensured it follows the project's coding standards.
  • I have tested the changes locally following ManualTestingProcess.md, and all tests related to this pull request pass.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation, if applicable.
  • I have added appropriate unit tests, if applicable.

Additional Notes

@dakshpokar dakshpokar force-pushed the feature/fmt-matplotlib-seaborn branch 2 times, most recently from 4aa85be to 39f4073 Compare August 25, 2024 21:44
@dakshpokar dakshpokar marked this pull request as ready for review August 26, 2024 04:48
@dakshpokar dakshpokar changed the title feat: pick up matplotlib and seaborn fmt towards maidr feat: pick up seaborn heatmap fmt towards maidr Aug 26, 2024
Copy link
Member

@jooyoungseo jooyoungseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you include example_bar_plot.ipynb here?

@dakshpokar
Copy link
Collaborator Author

Professor @jooyoungseo there was a stray print statement in the example notebook, that is what I removed.

@jooyoungseo
Copy link
Member

Thanks, @dakshpokar . The git diff is not supported in ipynb. Does the change have to do with this PR? Or is that a housekeeping chore unrelated to this one? If the latter is the case, please take that out. Otherwise, feel free to keep the change.

@dakshpokar
Copy link
Collaborator Author

Sure Professor, I think I will clean this up separately it is not related to this PR

@dakshpokar dakshpokar force-pushed the feature/fmt-matplotlib-seaborn branch from eb204e2 to 002dd5c Compare August 26, 2024 20:57
maidr/patch/heatmap.py Outdated Show resolved Hide resolved
maidr/patch/heatmap.py Outdated Show resolved Hide resolved
maidr/patch/heatmap.py Outdated Show resolved Hide resolved
maidr/core/plot/heatmap.py Outdated Show resolved Hide resolved
@SaaiVenkat SaaiVenkat merged commit fb5dde0 into xability:main Aug 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: pick up matplotlib fmt towards maidr
3 participants