-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pick up seaborn heatmap fmt towards maidr #90
feat: pick up seaborn heatmap fmt towards maidr #90
Conversation
4aa85be
to
39f4073
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you include example_bar_plot.ipynb
here?
Professor @jooyoungseo there was a stray print statement in the example notebook, that is what I removed. |
Thanks, @dakshpokar . The git diff is not supported in ipynb. Does the change have to do with this PR? Or is that a housekeeping chore unrelated to this one? If the latter is the case, please take that out. Otherwise, feel free to keep the change. |
Sure Professor, I think I will clean this up separately it is not related to this PR |
eb204e2
to
002dd5c
Compare
Description
This PR picks up the seaborn heatmap's fmt argument and applies it to the values displayed in maidr. This is done so by passing the argument fmt to the patched heatmap plot.
closes #77
Type of Change
Checklist
Pull Request
Description
Related Issues
Changes Made
Screenshots (if applicable)
Checklist
ManualTestingProcess.md
, and all tests related to this pull request pass.Additional Notes