Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix polygon mode mixin using face as mode #516

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix polygon mode mixin using face as mode #516

wants to merge 1 commit into from

Conversation

Fox2Code
Copy link

@Fox2Code Fox2Code commented Oct 5, 2024 •
edited
Loading

@Fox2Code
Copy link
Author

Fox2Code commented Oct 5, 2024

This PR fixes Not-Enough-Crashes compatibility issues.

@Fox2Code
Copy link
Author

@xCollateral can you review this please.

@Fox2Code Fox2Code force-pushed the gl_polygon_mode_1028 branch from e27c716 to d96438e Compare October 14, 2024 15:01
@Fox2Code Fox2Code changed the base branch from 1.21 to dev October 14, 2024 15:02
@Fox2Code
Copy link
Author

v2:

  • Rebased to dev branch
  • Removed null check for GlTexture.texParameteri, this will be moved into another PR

@Fox2Code
Copy link
Author

Null check has been replaced by proper implementation:

@Fox2Code
Copy link
Author

Note: @xCollateral want to do the commit himself, I keep this PR as a reminder for him.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Fox2Code