-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Language Module #1
base: main
Are you sure you want to change the base?
Conversation
Language.py is for detecting the Language of an audio track
modules/Language.py
Outdated
return None | ||
|
||
# Mapping of common language codes to full names in alphabetical order | ||
language_mapping = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to extend this to also support language tags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like mi, en, da, etc? or what tag format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also referred to as locales
. Here's another reference.
Personally example much of my library includes Arabic that's either dubbed into both classical/modern standard arabic (ar
) or egyptian arabic (ar-eg
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing that will need to be updated along with this is the main README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also referred to as
locales
. Here's another reference.Personally example much of my library includes Arabic that's either dubbed into both classical/modern standard arabic (
ar
) or egyptian arabic (ar-eg
).
My languages are based on language codes you would find in mkvtoolnix to define audio tracks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. So would I be using this designation going forward for any ar-eg
files?
@x1ao4 this would be a welcomed addition |
I've been a bit busy lately, but I'll review and consider this PR when I have some free time. |
Source, Size, FrameRate, Bitrate, AudioCodec and VideoCodec
@x1ao4 just a friendly nudge |
Added a Language Module so you can see what Language a movie is in. Also has ability to skip dual audio videos so you can just see files that have one audio track