Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Language Module #1

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

Added Language Module #1

wants to merge 44 commits into from

Conversation

Entree3k
Copy link

Added a Language Module so you can see what Language a movie is in. Also has ability to skip dual audio videos so you can just see files that have one audio track

Entree3k added 2 commits June 19, 2024 13:10
Language.py is for detecting the Language of an audio track
return None

# Mapping of common language codes to full names in alphabetical order
language_mapping = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to extend this to also support language tags?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like mi, en, da, etc? or what tag format?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also referred to as locales. Here's another reference.

Personally example much of my library includes Arabic that's either dubbed into both classical/modern standard arabic (ar) or egyptian arabic (ar-eg).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing that will need to be updated along with this is the main README

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also referred to as locales. Here's another reference.

Personally example much of my library includes Arabic that's either dubbed into both classical/modern standard arabic (ar) or egyptian arabic (ar-eg).

image
My languages are based on language codes you would find in mkvtoolnix to define audio tracks

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. So would I be using this designation going forward for any ar-eg files?

@amadib
Copy link

amadib commented Jul 5, 2024

@x1ao4 this would be a welcomed addition

@x1ao4
Copy link
Owner

x1ao4 commented Jul 5, 2024

@x1ao4 this would be a welcomed addition

I've been a bit busy lately, but I'll review and consider this PR when I have some free time.

@amadib
Copy link

amadib commented Jul 28, 2024

@x1ao4 just a friendly nudge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants