Skip mode deconflict #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`json.dumps()`/`json.loads()` are relatively slow (~1us). But these functions are likely to be called many times with `flow={1}`.
…tasks in the given flow(s)
- Update data store with changed prereqs - Don't un-queue downstream task if: - the task is already preparing - the task exists in flows other than that being removed - the task's prereqs are still satisfied overall - Remove the downstream task from the pool if it no longer has any satisfied prerequisite tasks
This will allow it to call the method to kill submitted/running tasks
Plus ensure traceback for internal errors when cleaning gets logged in verbose mode
MetRonnie
commented
Nov 28, 2024
Comment on lines
-655
to
+657
| for p_name in set(platform_names) - set(JOBLESS_MODES): | ||
| for p_name in set(platform_names): |
There was a problem hiding this comment.
The jobless logic here is not needed with my change to deep copy the localhost platform above
MetRonnie
commented
Nov 28, 2024
Comment on lines
-665
to
-668
| # Map jobless modes to localhost. | ||
| ret.setdefault('localhost', []).extend( | ||
| {'name': mode} for mode in JOBLESS_MODES | ||
| ) |
MetRonnie
commented
Nov 28, 2024
| to_kill.append(itask) | ||
| if jobless: |
There was a problem hiding this comment.
Note jobless is really is_sim_mode, see (above):
Line 1062 in b31f4ff
This doesn't matter because you can't kill a skip mode task as it goes straight from waiting to succeeded
wxtim
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.