tui: prevent hang on shutdown

* Add a timeout on the updater shutdown to prevent any hanging operation stopping Tui from exiting.
wxtim · Jun 28, 2024 · 33aeb2c · 33aeb2c
1 parent 747e2af
commit 33aeb2c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/changes.d/fix.6178.md b/changes.d/fix.6178.md
@@ -0,0 +1 @@
+Fix an issue where Tui could hang when closing.
diff --git a/cylc/flow/tui/app.py b/cylc/flow/tui/app.py
@@ -216,7 +216,10 @@ def updater_subproc(filters, client_timeout):
         yield updater
     finally:
         updater.terminate()
-        p.join()
+        p.join(4)  # timeout of 4 seconds
+        if p.exitcode is None:
+            # updater did not exit within timeout -> kill it
+            p.terminate()
 
 
 class TuiApp:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix an issue where Tui could hang when closing.